yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [RFC] proxy_pass: possibly avoid breaking some middlewares
Date: Tue, 7 Apr 2015 21:34:31 +0000	[thread overview]
Message-ID: <20150407213431.GA20108@dcvr.yhbt.net> (raw)

Running this on http://yhbt.net/yahns-public/ for now.  I originally I
forgot to disable one of my throwaway middlewares which was not aware of
Rack hijacking.

From: Eric Wong <e@80x24.org>
Subject: [PATCH] proxy_pass: possibly avoid breaking some middlewares

hijack seems incompatible with many middlewares, so return a
wonky response tuplet just in case...
---
 lib/yahns/proxy_pass.rb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/yahns/proxy_pass.rb b/lib/yahns/proxy_pass.rb
index e3ba7f0..48a61af 100644
--- a/lib/yahns/proxy_pass.rb
+++ b/lib/yahns/proxy_pass.rb
@@ -235,6 +235,9 @@ class Yahns::ProxyPass # :nodoc:
 
     # finally, prepare to emit the headers
     rr.req_start(c, req << "\r\n".freeze, input, chunked)
+
+    # this probably breaks fewer middlewares than returning whatever else...
+    [ 500, [], [] ]
   rescue => e
     Yahns::Log.exception(env['rack.logger'], 'proxy_pass', e)
     [ 502, [ %w(Content-Length 0), %w(Content-Type text/plain) ], [] ]
-- 
EW


             reply	other threads:[~2015-04-07 21:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 21:34 Eric Wong [this message]
2015-04-08 10:38 ` [RFC] proxy_pass: possibly avoid breaking some middlewares Lin Jen-Shin (godfat)
2015-04-08 17:03   ` Eric Wong
2015-04-08 17:23     ` Lin Jen-Shin (godfat)
2015-04-08 17:32       ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407213431.GA20108@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).