From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
 URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2
X-Original-To: yahns-public@yhbt.net
Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net
 (Postfix) with ESMTP id 53C93200C7; Wed,  8 Apr 2015 17:03:28 +0000 (UTC)
Date: Wed, 8 Apr 2015 17:03:28 +0000
From: Eric Wong <e@80x24.org>
To: "Lin Jen-Shin (godfat)" <godfat@godfat.org>
Cc: yahns-public@yhbt.net
Subject: Re: [RFC] proxy_pass: possibly avoid breaking some middlewares
Message-ID: <20150408170328.GA10903@dcvr.yhbt.net>
References: <20150407213431.GA20108@dcvr.yhbt.net>
 <CAA2_N1uy+adft1Wx3qKZaqB3dw9Wtg7Wp4jyzvxSZ8h86XZGcg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To:
 <CAA2_N1uy+adft1Wx3qKZaqB3dw9Wtg7Wp4jyzvxSZ8h86XZGcg@mail.gmail.com>
List-Id: <yahns-public@yhbt.net>

"Lin Jen-Shin (godfat)" <godfat@godfat.org> wrote:
> On Wed, Apr 8, 2015 at 5:34 AM, Eric Wong <e@80x24.org> wrote:
> > +    # this probably breaks fewer middlewares than returning whatever else...
> > +    [ 500, [], [] ]
> 
> You probably meant [ 500, {}, [] ] here?

No, arrays work fine, Rack headers just need to respond to #each
with key + value strings.

I prefer Arrays since they use less memory per-entry, but here they're
the same cost when empty.

But I'm also likely to revert this patch since it's no longer a drop-in
replacement and the old, synchronous ProxyPass is reinstated.