yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] proxy_pass: quiet down ECONNRESET and EPIPE, too
@ 2015-10-03 11:36 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-10-03 11:36 UTC (permalink / raw)
  To: yahns-public

Clients may disconnect on us while we're writing the response
here, so we should shut the backtrace up to avoid polluting
logs.
---
 lib/yahns/proxy_pass.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/yahns/proxy_pass.rb b/lib/yahns/proxy_pass.rb
index 89c6ef8..9512318 100644
--- a/lib/yahns/proxy_pass.rb
+++ b/lib/yahns/proxy_pass.rb
@@ -74,7 +74,10 @@ class Yahns::ProxyPass # :nodoc:
     rescue => e
       # avoid polluting logs with a giant backtrace when the problem isn't
       # fixable in code.
-      e.set_backtrace([]) if Errno::ECONNREFUSED === e
+      case e
+      when Errno::ECONNREFUSED, Errno::ECONNRESET, Errno::EPIPE
+        e.set_backtrace([])
+      end
       c.proxy_err_response(502, self, e, nil)
     end
 
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-10-03 11:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-03 11:36 [PATCH] proxy_pass: quiet down ECONNRESET and EPIPE, too Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).