yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] update various comments
Date: Tue, 13 Oct 2015 21:19:33 +0000	[thread overview]
Message-ID: <20151013211933.888-1-e@80x24.org> (raw)

Clarify APP_CONFIG is only public for modules maintained within
yahns, not external users.

While we're at it, avoid the http:// -> https:// redirect for
bugs.ruby-lang.org in the comment.
---
 lib/yahns/config.rb | 5 ++++-
 lib/yahns/log.rb    | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb
index faae9c9..e39115c 100644
--- a/lib/yahns/config.rb
+++ b/lib/yahns/config.rb
@@ -6,7 +6,10 @@
 # See http://yahns.yhbt.net/examples/yahns_multi.conf.rb for a full
 # example configuration file.
 class Yahns::Config # :nodoc:
-  APP_CLASS = {} # public, see yahns/rack for usage example
+  # public within yahns itself, NOT a public interface for users outside
+  # of yahns.  See yahns/rack for usage example
+  APP_CLASS = {}
+
   CfgBlock = Struct.new(:type, :ctx) # :nodoc:
   attr_reader :config_file, :config_listeners, :set
   attr_reader :qeggs, :app_ctx
diff --git a/lib/yahns/log.rb b/lib/yahns/log.rb
index a03c973..b8015c4 100644
--- a/lib/yahns/log.rb
+++ b/lib/yahns/log.rb
@@ -66,7 +66,7 @@ def self.reopen_all
           # MRI will use freopen(3) here internally on std{in,out,err}
           fp.reopen(fp.path, "a")
         else
-          # We should not need this: http://bugs.ruby-lang.org/issues/9036
+          # We should not need this: https://bugs.ruby-lang.org/issues/9036
           # MRI will not call call fclose(3) or freopen(3) here
           # since there's no associated std{in,out,err} FILE * pointer
           # This should atomically use dup3(2) (or dup2(2)) syscall
-- 
EW


                 reply	other threads:[~2015-10-13 21:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013211933.888-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).