yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] update various comments
@ 2015-10-13 21:19 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-10-13 21:19 UTC (permalink / raw)
  To: yahns-public

Clarify APP_CONFIG is only public for modules maintained within
yahns, not external users.

While we're at it, avoid the http:// -> https:// redirect for
bugs.ruby-lang.org in the comment.
---
 lib/yahns/config.rb | 5 ++++-
 lib/yahns/log.rb    | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb
index faae9c9..e39115c 100644
--- a/lib/yahns/config.rb
+++ b/lib/yahns/config.rb
@@ -6,7 +6,10 @@
 # See http://yahns.yhbt.net/examples/yahns_multi.conf.rb for a full
 # example configuration file.
 class Yahns::Config # :nodoc:
-  APP_CLASS = {} # public, see yahns/rack for usage example
+  # public within yahns itself, NOT a public interface for users outside
+  # of yahns.  See yahns/rack for usage example
+  APP_CLASS = {}
+
   CfgBlock = Struct.new(:type, :ctx) # :nodoc:
   attr_reader :config_file, :config_listeners, :set
   attr_reader :qeggs, :app_ctx
diff --git a/lib/yahns/log.rb b/lib/yahns/log.rb
index a03c973..b8015c4 100644
--- a/lib/yahns/log.rb
+++ b/lib/yahns/log.rb
@@ -66,7 +66,7 @@ def self.reopen_all
           # MRI will use freopen(3) here internally on std{in,out,err}
           fp.reopen(fp.path, "a")
         else
-          # We should not need this: http://bugs.ruby-lang.org/issues/9036
+          # We should not need this: https://bugs.ruby-lang.org/issues/9036
           # MRI will not call call fclose(3) or freopen(3) here
           # since there's no associated std{in,out,err} FILE * pointer
           # This should atomically use dup3(2) (or dup2(2)) syscall
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-10-13 21:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-13 21:19 [PATCH] update various comments Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).