yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] test_server: fix race condition in hooks test
@ 2015-12-13  2:03 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-12-13  2:03 UTC (permalink / raw)
  To: yahns-public

We need to ensure the master process is done writing to logs
when we check them.  Do that by sending a SIGQUIT to the master
to shut it down, as the master process will defer the SIGQUIT
until after the test log is written to the kernel.
---
 test/test_server.rb | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/test/test_server.rb b/test/test_server.rb
index 2ed43a1..c753919 100644
--- a/test/test_server.rb
+++ b/test/test_server.rb
@@ -433,7 +433,7 @@ class TestServer < Testcase
       stderr_path err.path
       stdout_path out.path
     end
-    pid = mkserver(cfg)
+    master_pid = pid = mkserver(cfg)
     c = get_tcp_client(host, port)
     c.write("GET / HTTP/1.0\r\nHost: example.com\r\n\r\n")
     buf = Timeout.timeout(10) { c.read }
@@ -442,19 +442,24 @@ class TestServer < Testcase
     assert_match(/200 OK/, head)
     assert_match(/\A\d+\z/, body)
     worker_pid = body.to_i
+
+    # ensure atfork_parent has run
+    quit_wait(master_pid)
+    master_pid = nil
+
     lines = out.readlines.map!(&:chomp!)
     out.close!
 
     assert_match %r{INFO hihi from app\.atfork_child}, File.read(err.path)
 
-    assert_equal 3, lines.size
+    assert_equal 3, lines.size, lines.join("\n")
     assert_equal("af #{pid} parent about to spawn", lines.shift)
 
     # child/parent ordering is not guaranteed
     assert_equal 1, lines.grep(/\Aaf #{pid} this is probably not useful\z/).size
     assert_equal 1, lines.grep(/\Aaf #{worker_pid} worker is running\z/).size
   ensure
-    quit_wait(pid)
+    quit_wait(master_pid)
   end
 
   def test_mp_hooks_worker_nr
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-12-13  2:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-13  2:03 [PATCH] test_server: fix race condition in hooks test Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).