From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, T_RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: yahns-public@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id AF57020442 for ; Sun, 13 Dec 2015 02:03:50 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH] test_server: fix race condition in hooks test Date: Sun, 13 Dec 2015 02:03:50 +0000 Message-Id: <20151213020350.4064-1-e@80x24.org> List-Id: We need to ensure the master process is done writing to logs when we check them. Do that by sending a SIGQUIT to the master to shut it down, as the master process will defer the SIGQUIT until after the test log is written to the kernel. --- test/test_server.rb | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/test/test_server.rb b/test/test_server.rb index 2ed43a1..c753919 100644 --- a/test/test_server.rb +++ b/test/test_server.rb @@ -433,7 +433,7 @@ class TestServer < Testcase stderr_path err.path stdout_path out.path end - pid = mkserver(cfg) + master_pid = pid = mkserver(cfg) c = get_tcp_client(host, port) c.write("GET / HTTP/1.0\r\nHost: example.com\r\n\r\n") buf = Timeout.timeout(10) { c.read } @@ -442,19 +442,24 @@ class TestServer < Testcase assert_match(/200 OK/, head) assert_match(/\A\d+\z/, body) worker_pid = body.to_i + + # ensure atfork_parent has run + quit_wait(master_pid) + master_pid = nil + lines = out.readlines.map!(&:chomp!) out.close! assert_match %r{INFO hihi from app\.atfork_child}, File.read(err.path) - assert_equal 3, lines.size + assert_equal 3, lines.size, lines.join("\n") assert_equal("af #{pid} parent about to spawn", lines.shift) # child/parent ordering is not guaranteed assert_equal 1, lines.grep(/\Aaf #{pid} this is probably not useful\z/).size assert_equal 1, lines.grep(/\Aaf #{worker_pid} worker is running\z/).size ensure - quit_wait(pid) + quit_wait(master_pid) end def test_mp_hooks_worker_nr -- EW