[PUSHED] frozen_string_literal and copyright updates

[PUSHED] frozen_string_literal and copyright updates

[Eric Wong]

Two giant tree-wide changes pushed to master, if you have questions or
comments, reply with the commit subject line so the search engines can
find it:

      enable frozen_string_literal for Ruby 2.3+
      copyright updates for 2016

 93 files changed, 337 insertions(+), 253 deletions(-)

Also, the cgit instance @ http://yhbt.net/yahns.git/ will soon be
replaced with something friendlier to non-CSS users (and with
better mail integration to boot).

http://yhbt.net/yahns.git/patch?id=ddea1b7e04b7e3475bb615c35e2156c9626b4eac
http://yhbt.net/yahns.git/commit?id=ddea1b7e04b7e3475bb615c35e2156c9626b4eac

    copyright updates for 2016
    
    Using the 'update-copyright' script from gnulib[1]:
    
      git ls-files | UPDATE_COPYRIGHT_HOLDER='all contributors' \
          UPDATE_COPYRIGHT_USE_INTERVALS=2 \
          xargs /path/to/gnulib/build-aux/update-copyright
    
    We're also switching to 'GPL-3.0+' as recommended by SPDX
    to be consistent with our gemspec and other metadata
    (as opposed to the longer but equivalent "GPLv3 or later").
    
    [1] git://git.savannah.gnu.org/gnulib.git

http://yhbt.net/yahns.git/patch?id=9e24bae3428f726800da2963a8f2695f7d4064cd
http://yhbt.net/yahns.git/commit?id=9e24bae3428f726800da2963a8f2695f7d4064cd

    enable frozen_string_literal for Ruby 2.3+
    
    There are likely yet-to-be-discovered bugs in here.
    Also, keeping explicit #freeze calls for 2.2 users, since most
    users have not migrated to 2.3, yet.

-- 
EW

Re: [PUSHED] frozen_string_literal and copyright updates

[Eric Wong]

Eric Wong <e@80x24.org> wrote:
>     enable frozen_string_literal for Ruby 2.3+
>
>     There are likely yet-to-be-discovered bugs in here.

Yep...

http://yhbt.net/yahns.git/patch?id=e502a8e21e597895ccb6508b35af1d975c33aeb0
http://yhbt.net/yahns.git/commit?id=e502a8e21e597895ccb6508b35af1d975c33aeb0

    avoid StringIO#binmode for the next few years

    Apparently, StringIO#binmode has been totally broken in 1.9+ and
    I've always hidden this bug with the combination of an explicit
    string and magic "encoding: binary" comments :x

    ref: https://bugs.ruby-lang.org/issues/11945

http://yhbt.net/yahns.git/patch?id=6ea85b061e650cfe348ece306a13d568559fb844
http://yhbt.net/yahns.git/commit?id=6ea85b061e650cfe348ece306a13d568559fb844

    extras/exec_cgi: fix frozen string error on slow responses

    Oops, we need to duplicate our buffer in case the CGI executable
    returns just the header :x