From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.8 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: yahns-public@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id EE1A7201D7; Mon, 4 Jan 2016 12:06:31 +0000 (UTC) Date: Mon, 4 Jan 2016 12:06:31 +0000 From: Eric Wong To: yahns-public@yhbt.net Subject: Re: [PUSHED] frozen_string_literal and copyright updates Message-ID: <20160104120631.GA8391@dcvr.yhbt.net> References: <20160102224737.GA787@dcvr.yhbt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160102224737.GA787@dcvr.yhbt.net> List-Id: Eric Wong wrote: > enable frozen_string_literal for Ruby 2.3+ > > There are likely yet-to-be-discovered bugs in here. Yep... http://yhbt.net/yahns.git/patch?id=e502a8e21e597895ccb6508b35af1d975c33aeb0 http://yhbt.net/yahns.git/commit?id=e502a8e21e597895ccb6508b35af1d975c33aeb0 avoid StringIO#binmode for the next few years Apparently, StringIO#binmode has been totally broken in 1.9+ and I've always hidden this bug with the combination of an explicit string and magic "encoding: binary" comments :x ref: https://bugs.ruby-lang.org/issues/11945 http://yhbt.net/yahns.git/patch?id=6ea85b061e650cfe348ece306a13d568559fb844 http://yhbt.net/yahns.git/commit?id=6ea85b061e650cfe348ece306a13d568559fb844 extras/exec_cgi: fix frozen string error on slow responses Oops, we need to duplicate our buffer in case the CGI executable returns just the header :x