yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH 5/3] proxy_pass: pass X-Forwarded-Proto through
Date: Sat, 13 Feb 2016 22:50:03 +0000	[thread overview]
Message-ID: <20160213225003.GA14098@dcvr.yhbt.net> (raw)
In-Reply-To: <20160212014713.32163-1-e@80x24.org>

This allows backend application servers to set "rack.url_scheme"
as appropriate using Rack::Request#scheme.

Plack/PSGI users can also take advantage of this using
Plack::Middleware::ReverseProxy
---
  Eric Wong <e@80x24.org> wrote:
  > Things like rack.url_scheme, SERVER_NAME, SERVER_PORT, etc...
  > will all need to be set properly.

 lib/yahns/proxy_pass.rb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/yahns/proxy_pass.rb b/lib/yahns/proxy_pass.rb
index 3b68f01..511db02 100644
--- a/lib/yahns/proxy_pass.rb
+++ b/lib/yahns/proxy_pass.rb
@@ -226,6 +226,7 @@ def call(env)
     end
 
     req = "#{env['REQUEST_METHOD']} #{req} #{ver}\r\n" \
+          "X-Forwarded-Proto: #{env['rack.url_scheme']}\r\n" \
           "X-Forwarded-For: #{env["REMOTE_ADDR"]}\r\n".dup
 
     # pass most HTTP_* headers through as-is
-- 
EW


      parent reply	other threads:[~2016-02-13 22:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12  1:47 [PATCH 0/3] TLS fixes Eric Wong
2016-02-12  1:47 ` [PATCH 1/3] acceptor: all subclasses of TCPServer use TCP_INFO Eric Wong
2016-02-12  1:47 ` [PATCH 2/3] properly emulate sendfile for OpenSSL sockets Eric Wong
2016-02-12  1:47 ` [PATCH 3/3] avoid race conditions in OpenSSL::SSL::SSLContext#setup Eric Wong
2016-02-12  4:05 ` [PATCH 4/3] set HTTPS and rack.url_scheme in Rack env as appropriate Eric Wong
2016-02-13 22:50 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160213225003.GA14098@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).