Re: [PATCH] proxy_http_response: workaround non-terminated backends

[Eric Wong <e@80x24.org>]

Eric Wong <e@80x24.org> wrote:
> @@ -232,7 +247,7 @@ def proxy_response_finish(kcar, wbuf, req_res)
>      end
>  
>      busy = wbuf.busy and return proxy_busy_mod_blocked(wbuf, busy)
> -    proxy_busy_mod_done(wbuf.wbuf_persist) # returns nil
> +    proxy_busy_mod_done(alive) # returns nil
>    end
>  
>    def proxy_wait_next(qflags)

Hm... that seems wrong,  The following fixup commit may be necessary.
Letting it run on our site for a few days before writing a commit
message and committing.  (Not really in a state of mind to be hacking
this time of year, but I noticed some high FD usage...)

--- a/lib/yahns/proxy_http_response.rb
+++ b/lib/yahns/proxy_http_response.rb
@@ -247,7 +247,7 @@ def proxy_response_finish(kcar, wbuf, req_res)
     end
 
     busy = wbuf.busy and return proxy_busy_mod_blocked(wbuf, busy)
-    proxy_busy_mod_done(alive) # returns nil
+    proxy_busy_mod_done(alive && wbuf.wbuf_persist) # returns nil
   end
 
   def proxy_wait_next(qflags)