yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: Re: [PATCH] proxy_http_response: workaround non-terminated backends
Date: Sat, 16 Apr 2016 08:17:12 +0000	[thread overview]
Message-ID: <20160416081712.GA21868@dcvr.yhbt.net> (raw)
In-Reply-To: <20160406062556.10988-1-e@80x24.org>

Eric Wong <e@80x24.org> wrote:
> @@ -232,7 +247,7 @@ def proxy_response_finish(kcar, wbuf, req_res)
>      end
>      busy = wbuf.busy and return proxy_busy_mod_blocked(wbuf, busy)
> -    proxy_busy_mod_done(wbuf.wbuf_persist) # returns nil
> +    proxy_busy_mod_done(alive) # returns nil
>    end
>    def proxy_wait_next(qflags)

Hm... that seems wrong,  The following fixup commit may be necessary.
Letting it run on our site for a few days before writing a commit
message and committing.  (Not really in a state of mind to be hacking
this time of year, but I noticed some high FD usage...)

--- a/lib/yahns/proxy_http_response.rb
+++ b/lib/yahns/proxy_http_response.rb
@@ -247,7 +247,7 @@ def proxy_response_finish(kcar, wbuf, req_res)
     busy = wbuf.busy and return proxy_busy_mod_blocked(wbuf, busy)
-    proxy_busy_mod_done(alive) # returns nil
+    proxy_busy_mod_done(alive && wbuf.wbuf_persist) # returns nil
   def proxy_wait_next(qflags)

  reply	other threads:[~2016-04-16  8:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06  6:25 [PATCH] proxy_http_response: workaround non-terminated backends Eric Wong
2016-04-16  8:17 ` Eric Wong [this message]
2016-04-22  0:13   ` [PATCH] proxy_pass: honor wbuf_persist when ending response Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160416081712.GA21868@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).