From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
 URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2
X-Original-To: yahns-public@yhbt.net
Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net
 (Postfix) with ESMTP id 249F32043F; Sat, 16 Apr 2016 08:17:12 +0000 (UTC)
Date: Sat, 16 Apr 2016 08:17:12 +0000
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: Re: [PATCH] proxy_http_response: workaround non-terminated backends
Message-ID: <20160416081712.GA21868@dcvr.yhbt.net>
References: <20160406062556.10988-1-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160406062556.10988-1-e@80x24.org>
List-Id: <yahns-public@yhbt.net>

Eric Wong <e@80x24.org> wrote:
> @@ -232,7 +247,7 @@ def proxy_response_finish(kcar, wbuf, req_res)
>      end
>  
>      busy = wbuf.busy and return proxy_busy_mod_blocked(wbuf, busy)
> -    proxy_busy_mod_done(wbuf.wbuf_persist) # returns nil
> +    proxy_busy_mod_done(alive) # returns nil
>    end
>  
>    def proxy_wait_next(qflags)

Hm... that seems wrong,  The following fixup commit may be necessary.
Letting it run on our site for a few days before writing a commit
message and committing.  (Not really in a state of mind to be hacking
this time of year, but I noticed some high FD usage...)

--- a/lib/yahns/proxy_http_response.rb
+++ b/lib/yahns/proxy_http_response.rb
@@ -247,7 +247,7 @@ def proxy_response_finish(kcar, wbuf, req_res)
     end
 
     busy = wbuf.busy and return proxy_busy_mod_blocked(wbuf, busy)
-    proxy_busy_mod_done(alive) # returns nil
+    proxy_busy_mod_done(alive && wbuf.wbuf_persist) # returns nil
   end
 
   def proxy_wait_next(qflags)