yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] proxy_http_response: fix non-terminated fast responses, too
Date: Thu, 21 Apr 2016 23:52:13 +0000	[thread overview]
Message-ID: <20160421235213.13975-1-e@80x24.org> (raw)

Without this, non-terminated backends were not properly
supported if they gave tiny responses or responded faster
than we could stream the response to the client.

This is necessary to support fast responses from some non-Rack
HTTP/1.0-only backend servers which rely on connection
termination to terminate responses.

Tested manually with a Perl PSGI application running under
"plackup".  Unlike Rack, the PSGI spec does not specify whether
the PSGI application or PSGI server should handle response
termination: git clone https://github.com/plack/psgi-specs.git

Follow-up-to: 8c9f33a5396d2 ("workaround non-terminated backends")
---
 lib/yahns/proxy_http_response.rb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/yahns/proxy_http_response.rb b/lib/yahns/proxy_http_response.rb
index 3fc522d..f38cd34 100644
--- a/lib/yahns/proxy_http_response.rb
+++ b/lib/yahns/proxy_http_response.rb
@@ -168,6 +168,7 @@ def proxy_response_start(res, tip, kcar, req_res)
           tmp = chunk_out(tmp) if alive
           wbuf = proxy_write(wbuf, tmp, alive)
         when nil
+          wbuf = proxy_write(wbuf, "0\r\n\r\n".freeze, true) if alive
           req_res.shutdown
           break
         when :wait_readable
-- 
EW


                 reply	other threads:[~2016-04-21 23:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160421235213.13975-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).