yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH 2/5] wbuf: drop persistence if writing to client fails
Date: Wed, 27 Apr 2016 00:27:01 +0000	[thread overview]
Message-ID: <20160427002704.10660-3-e@80x24.org> (raw)
In-Reply-To: <20160427002704.10660-1-e@80x24.org>

We cannot maintain a persistent connection to a client if
writing to the client fails; so we can't proceed to let
the app hijack the response.

This may happen in the unlikely case where a response
header needs to be buffered with a Wbuf (and the app
uses response hijacking).
 lib/yahns/wbuf_common.rb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/yahns/wbuf_common.rb b/lib/yahns/wbuf_common.rb
index c51050b..ee18218 100644
--- a/lib/yahns/wbuf_common.rb
+++ b/lib/yahns/wbuf_common.rb
@@ -38,6 +38,7 @@ def wbuf_flush(client)
     end while @sf_count > 0
+    @wbuf_persist = false # ensure a hijack response is not called

  parent reply	other threads:[~2016-04-27  0:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27  0:26 [PATCH 0/5] proxy_pass resource cleanup fixes Eric Wong
2016-04-27  0:27 ` [PATCH 1/5] test_proxy_pass: test for auto chunking on 1.0 backends Eric Wong
2016-04-27  0:27 ` Eric Wong [this message]
2016-04-27  0:27 ` [PATCH 3/5] proxy_http_response: cleanup: avoid redundant setting of "alive" Eric Wong
2016-04-27  0:27 ` [PATCH 4/5] proxy_http_response: do not persist upstream on slow clients Eric Wong
2016-04-27  0:27 ` [PATCH 5/5] proxy_pass: drop resources immediately on errors Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427002704.10660-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).