yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH 3/5] proxy_http_response: cleanup: avoid redundant setting of "alive"
Date: Wed, 27 Apr 2016 00:27:02 +0000	[thread overview]
Message-ID: <20160427002704.10660-4-e@80x24.org> (raw)
In-Reply-To: <20160427002704.10660-1-e@80x24.org>

We already check for the truthiness of "alive" in the "if"
statement, so re-setting is pointless.
---
 lib/yahns/proxy_http_response.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/yahns/proxy_http_response.rb b/lib/yahns/proxy_http_response.rb
index c8a2a42..e551323 100644
--- a/lib/yahns/proxy_http_response.rb
+++ b/lib/yahns/proxy_http_response.rb
@@ -101,7 +101,6 @@ def proxy_response_start(res, tip, kcar, req_res)
     # but the backend does not terminate properly
     if alive && ! term && (env['HTTP_VERSION'] == 'HTTP/1.1'.freeze)
       res << "Transfer-Encoding: chunked\r\n".freeze
-      alive = true
     end
     res << (alive ? "Connection: keep-alive\r\n\r\n".freeze
                   : "Connection: close\r\n\r\n".freeze)
-- 
EW


  parent reply	other threads:[~2016-04-27  0:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27  0:26 [PATCH 0/5] proxy_pass resource cleanup fixes Eric Wong
2016-04-27  0:27 ` [PATCH 1/5] test_proxy_pass: test for auto chunking on 1.0 backends Eric Wong
2016-04-27  0:27 ` [PATCH 2/5] wbuf: drop persistence if writing to client fails Eric Wong
2016-04-27  0:27 ` Eric Wong [this message]
2016-04-27  0:27 ` [PATCH 4/5] proxy_http_response: do not persist upstream on slow clients Eric Wong
2016-04-27  0:27 ` [PATCH 5/5] proxy_pass: drop resources immediately on errors Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427002704.10660-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).