yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* corking headers on Transfer-Encoding:chunked
@ 2016-04-29  7:35 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-04-29  7:35 UTC (permalink / raw)
  To: yahns-public

I don't think I can safely apply the following patch,
at least I don't think we can do it by default.
I wish I could, given how I always use Rack::Deflater:

--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -152,6 +152,9 @@ def http_response_write(status, headers, body)
         when %r{\AContent-Length\z}i
           flags |= MSG_MORE if have_more?(value)
           kv_str(buf, key, value)
+        when %r{\ATransfer-Encoding\z}i && value =~ /\bchunked\b/i
+          flags |= MSG_MORE
+          kv_str(buf, key, value)
         when "rack.hijack"
           hijack = value
         else

Problem is, we never know how long it'll take an app to
generate the first part of the response body in:

	body.each { |chunk| ... }

And it is likely somebody might want to send a header out
ASAP, making the 200ms MSG_MORE delay unnacceptable; right?

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-29  7:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-29  7:35 corking headers on Transfer-Encoding:chunked Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).