yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] proxy_pass: X-Forwarded-For appends to existing list
Date: Tue, 31 May 2016 04:18:03 +0000	[thread overview]
Message-ID: <20160531041803.15731-1-e@80x24.org> (raw)

Ugh, this is a little slower, but some people will want to
forward through multiple proxies.
---
 lib/yahns/proxy_pass.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/yahns/proxy_pass.rb b/lib/yahns/proxy_pass.rb
index 8e0b742..a30089d 100644
--- a/lib/yahns/proxy_pass.rb
+++ b/lib/yahns/proxy_pass.rb
@@ -59,9 +59,12 @@ def call(env)
       ver = 'HTTP/1.0'.freeze
     end
 
+    addr = env['REMOTE_ADDR']
+    xff = env['HTTP_X_FORWARDED_FOR']
+    xff = xff =~ /\S/ ? "#{xff}, #{addr}" : addr
     req = "#{env['REQUEST_METHOD']} #{req} #{ver}\r\n" \
           "X-Forwarded-Proto: #{env['rack.url_scheme']}\r\n" \
-          "X-Forwarded-For: #{env["REMOTE_ADDR"]}\r\n".dup
+          "X-Forwarded-For: #{xff}\r\n".dup
 
     # pass most HTTP_* headers through as-is
     chunked = false

                 reply	other threads:[~2016-05-31  4:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160531041803.15731-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).