From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH 3/2] proxy_pass: remove unnecessary rescue
Date: Fri, 3 Jun 2016 01:58:51 +0000 [thread overview]
Message-ID: <20160603015851.GA30192@dcvr.yhbt.net> (raw)
In-Reply-To: <20160603012837.19143-1-e@80x24.org>
"proxy_response_start" caller is ReqRes#yahns_step which
already does a global rescue. Furthermore, it clobbers
backtraces on network errors which programmers can do
nothing to fix.
---
lib/yahns/proxy_http_response.rb | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/yahns/proxy_http_response.rb b/lib/yahns/proxy_http_response.rb
index 79b995a..2968062 100644
--- a/lib/yahns/proxy_http_response.rb
+++ b/lib/yahns/proxy_http_response.rb
@@ -220,8 +220,6 @@ def proxy_response_start(res, tip, kcar, req_res)
# all done reading response from upstream, req_res will be discarded
# when we return nil:
proxy_busy_mod(wbuf, req_res)
- rescue => e
- proxy_err_response(502, req_res, e, wbuf)
end
def proxy_response_finish(kcar, wbuf, req_res)
prev parent reply other threads:[~2016-06-03 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 1:28 [PATCH 0/2] proxy_pass: allow disabling proxy buffering Eric Wong
2016-06-03 1:28 ` [PATCH 1/2] proxy_pass: pass entire object to proxy_http_response Eric Wong
2016-06-03 1:28 ` [PATCH 2/2] proxy_pass: support "proxy_buffering: false" Eric Wong
2016-06-03 1:58 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603015851.GA30192@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).