From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] openssl_client: wrap shutdown for graceful termination
Date: Sun, 3 Jul 2016 23:18:56 +0000 [thread overview]
Message-ID: <20160703231856.15120-1-e@80x24.org> (raw)
When we call shutdown on bad upstream responses, we need
to ensure the TLS connection is terminated properly by
calling SSL_shutdown and avoiding confusion on the client
side.
---
lib/yahns/openssl_client.rb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/yahns/openssl_client.rb b/lib/yahns/openssl_client.rb
index cd7d210..f896acd 100644
--- a/lib/yahns/openssl_client.rb
+++ b/lib/yahns/openssl_client.rb
@@ -93,6 +93,10 @@ def trysendfile(io, offset, count)
rv
end
+ def shutdown # we never call this with a how=SHUT_* arg
+ @ssl.sysclose
+ end
+
def close
@ssl.close # flushes SSLSocket
super # IO#close
--
EW
reply other threads:[~2016-07-03 23:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160703231856.15120-1-e@80x24.org \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).