yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] openssl_client: wrap shutdown for graceful termination
@ 2016-07-03 23:18 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-07-03 23:18 UTC (permalink / raw)
  To: yahns-public

When we call shutdown on bad upstream responses, we need
to ensure the TLS connection is terminated properly by
calling SSL_shutdown and avoiding confusion on the client
side.
---
 lib/yahns/openssl_client.rb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/yahns/openssl_client.rb b/lib/yahns/openssl_client.rb
index cd7d210..f896acd 100644
--- a/lib/yahns/openssl_client.rb
+++ b/lib/yahns/openssl_client.rb
@@ -93,6 +93,10 @@ def trysendfile(io, offset, count)
     rv
   end
 
+  def shutdown # we never call this with a how=SHUT_* arg
+    @ssl.sysclose
+  end
+
   def close
     @ssl.close # flushes SSLSocket
     super # IO#close
-- 
@@ -93,6 +93,10 @@ def trysendfile(io, offset, count)
     rv
   end
 
+  def shutdown # we never call this with a how=SHUT_* arg
+    @ssl.sysclose
+  end
+
   def close
     @ssl.close # flushes SSLSocket
     super # IO#close
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-07-03 23:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-03 23:18 [PATCH] openssl_client: wrap shutdown for graceful termination Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).