yahns Ruby server user/dev discussion
 help / color / Atom feed
* [PATCH] proxy_pass: keep trailer buffer on blocked client writes
@ 2016-07-04 11:15 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-07-04 11:15 UTC (permalink / raw)
  To: yahns-public

When breaking early out of the upstream response body loop, we
must ensure we know we've hit the parser body EOF and preserve
the buffer for trailer parsing.  Otherwise, reentering
proxy_read_body will put us in a bad state and corrupt
responses.

This is a critical bugfix which only affects users of
the soon-to-be-released "proxy_buffering: false" feature
of proxy_pass.
---
  Fwiw, I discovered this using dumb git HTTP clones in a dumb
  configuration:

	yahns (proxy_pass) -> varnish -> dumb HTTP server

  GIT_SMART_HTTP=0 git -c http.maxRequests=100 clone $URL_OF_YAHNS

  But it's a decent HTTP server test for finding bugs like these
  since git checksums object responses to detect corruption.

  And damn, dumb HTTP in git is really slow at cloning a 750M
  repo (I guess one problem is the tree layout is really bad
  for this...) :<

 lib/yahns/proxy_http_response.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/yahns/proxy_http_response.rb b/lib/yahns/proxy_http_response.rb
index 316c310..0ca2c34 100644
--- a/lib/yahns/proxy_http_response.rb
+++ b/lib/yahns/proxy_http_response.rb
@@ -167,7 +167,10 @@ def proxy_read_body(tip, kcar, req_res)
       end
       wbuf = proxy_write(wbuf, tmp, req_res)
       chunk.clear if chunk
-      return proxy_unbuffer(wbuf) if Yahns::WbufLite === wbuf
+      if Yahns::WbufLite === wbuf
+        req_res.proxy_trailers = [ rbuf.dup, tip ] if chunk && kcar.body_eof?
+        return proxy_unbuffer(wbuf)
+      end
     when nil # EOF
       # HTTP/1.1 upstream, unexpected premature EOF:
       msg = "upstream EOF (#{len} bytes left)" if len

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 11:15 [PATCH] proxy_pass: keep trailer buffer on blocked client writes Eric Wong

yahns Ruby server user/dev discussion

Archives are clonable:
	git clone --mirror https://yhbt.net/yahns-public
	git clone --mirror http://ou63pmih66umazou.onion/yahns-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.yahns

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox