yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH 0/3] another round of proxy_pass fixes
Date: Tue,  5 Jul 2016 13:50:13 +0000	[thread overview]
Message-ID: <20160705135016.14274-1-e@80x24.org> (raw)

I really hope this will be the last round of critical fixes :)

Stress-tested numerous times on a yet-to-be-public 800M+ git
repo over dumb HTTP cloning:

	GIT_SMART_HTTP=0 git clone (client)
	yahns HTTP/HTTPS proxy_pass(proxy_buffering: false)
	varnish 4.0.2 (random chunks results,
		       even given Content-Length :p)
	static file server (with some dynamic parts)

Eric Wong (3):
      proxy_pass: avoid TOCTTOU race when unbuffering, too
      proxy_pass: avoid accessing logger in env after hijacking
      proxy_pass: avoid stuck responses in "proxy_buffering: false"

 lib/yahns/proxy_http_response.rb | 8 +++-----
 lib/yahns/wbuf_lite.rb           | 8 ++++++--
 2 files changed, 9 insertions(+), 7 deletions(-)

P.S. and git dumb HTTP cloning could probably be better about
memory/CPU usage...

             reply	other threads:[~2016-07-05 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05 13:50 Eric Wong [this message]
2016-07-05 13:50 ` [PATCH 1/3] proxy_pass: avoid TOCTTOU race when unbuffering, too Eric Wong
2016-07-05 13:50 ` [PATCH 2/3] proxy_pass: avoid accessing logger in env after hijacking Eric Wong
2016-07-05 13:50 ` [PATCH 3/3] proxy_pass: avoid stuck responses in "proxy_buffering: false" Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705135016.14274-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).