yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH 3/3] wbuf_lite: truncate StringIO when done
Date: Tue, 12 Jul 2016 21:41:03 +0000	[thread overview]
Message-ID: <20160712214103.12282-4-e@80x24.org> (raw)
In-Reply-To: <20160712214103.12282-1-e@80x24.org>

And explain why this is doable for StringIO and not TmpIO,
which is file-backed.
 lib/yahns/wbuf_lite.rb | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/yahns/wbuf_lite.rb b/lib/yahns/wbuf_lite.rb
index 2da5349..1902ce7 100644
--- a/lib/yahns/wbuf_lite.rb
+++ b/lib/yahns/wbuf_lite.rb
@@ -108,6 +108,12 @@ def wbuf_close(client)
   def wbuf_abort
-    @tmpio = @tmpio.close if @tmpio
+    # we can safely truncate since this is a StringIO, we cannot do this
+    # with a real file because zero-copy with sendfile means truncating
+    # a while could clobber in-flight data
+    if @tmpio
+      @tmpio.truncate(0)
+      @tmpio = @tmpio.close
+    end

      parent reply	other threads:[~2016-07-12 21:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 21:41 [PATCH 0/3] maybe the last round of proxy_pass fixes before 1.13 Eric Wong
2016-07-12 21:41 ` [PATCH 1/3] test_proxy_pass_no_buffering: exclude rb/ru files, too Eric Wong
2016-07-12 21:41 ` [PATCH 2/3] wbuf_lite: use StringIO instead of TmpIO Eric Wong
2016-07-12 21:41 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712214103.12282-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    --subject='Re: [PATCH 3/3] wbuf_lite: truncate StringIO when done' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).