From: Eric Wong <e@80x24.org> To: yahns-public@yhbt.net Subject: [PATCH 4/4] Revert "document Rack::Chunked/ContentLength semi-requirements" Date: Wed, 3 Aug 2016 03:19:06 +0000 [thread overview] Message-ID: <20160803031906.14553-5-e@80x24.org> (raw) In-Reply-To: <20160803031906.14553-1-e@80x24.org> Actually, I guess I misread, rack (starting at) 1.0 stopped requiring Content-Length/Chunked headers but I never noticed. Oh well. This reverts commit 4968041a7e1ff90b920704f50fccb9e7968d0d99. --- Documentation/yahns-rackup.pod | 10 ---------- examples/yahns_rack_basic.conf.rb | 6 ------ 2 files changed, 16 deletions(-) diff --git a/Documentation/yahns-rackup.pod b/Documentation/yahns-rackup.pod index 6172661..efdfb6d 100644 --- a/Documentation/yahns-rackup.pod +++ b/Documentation/yahns-rackup.pod @@ -159,16 +159,6 @@ The RACK_ENV variable is set by the aforementioned -E switch. If RACK_ENV is already set, it will be used unless -E is used. See rackup documentation for more details. -=head1 CAVEATS - -yahns is strict about buggy, non-compliant Rack applications. -Some existing servers work fine without "Content-Length" or -"Transfer-Encoding: chunked" response headers enforced by Rack::Lint. -Forgetting these headers with yahns causes clients to stall as they -assume more data is coming. Loading the Rack::ContentLength and/or -Rack::Chunked middlewares will set the necessary response headers -and fix your app. - =head1 CONTACT All feedback welcome via plain-text mail to L<mailto:yahns-public@yhbt.net> diff --git a/examples/yahns_rack_basic.conf.rb b/examples/yahns_rack_basic.conf.rb index 610a482..f3f8e6a 100644 --- a/examples/yahns_rack_basic.conf.rb +++ b/examples/yahns_rack_basic.conf.rb @@ -30,12 +30,6 @@ worker_threads 50 end -# note: Rack requires responses set "Content-Length" or use -# "Transfer-Encoding: chunked". Some Rack servers tolerate -# the lack of these, yahns does not. Thus you should load -# Rack::Chunked and/or Rack::ContentLength middleware in your -# config.ru to ensure clients know when your application -# responses terminate. app(:rack, "config.ru", preload: false) do listen 80 -- EW
prev parent reply other threads:[~2016-08-03 3:19 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-03 3:19 [PATCH 0/4] remove chunked/Content-Length requirement from apps Eric Wong 2016-08-03 3:19 ` [PATCH 1/4] response: drop clients after HTTP responses of unknown length Eric Wong 2016-08-03 3:19 ` [PATCH 2/4] response: reduce stack overhead for parameter passing Eric Wong 2016-08-03 3:19 ` [PATCH 3/4] response: support auto-chunking for HTTP/1.1 Eric Wong 2016-08-03 3:19 ` Eric Wong [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/yahns/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160803031906.14553-5-e@80x24.org \ --to=e@80x24.org \ --cc=yahns-public@yhbt.net \ --subject='Re: [PATCH 4/4] Revert "document Rack::Chunked/ContentLength semi-requirements"' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: ../../yahns.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).