From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9060E2022B for ; Wed, 3 Aug 2016 03:19:10 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH 4/4] Revert "document Rack::Chunked/ContentLength semi-requirements" Date: Wed, 3 Aug 2016 03:19:06 +0000 Message-Id: <20160803031906.14553-5-e@80x24.org> In-Reply-To: <20160803031906.14553-1-e@80x24.org> References: <20160803031906.14553-1-e@80x24.org> List-Id: Actually, I guess I misread, rack (starting at) 1.0 stopped requiring Content-Length/Chunked headers but I never noticed. Oh well. This reverts commit 4968041a7e1ff90b920704f50fccb9e7968d0d99. --- Documentation/yahns-rackup.pod | 10 ---------- examples/yahns_rack_basic.conf.rb | 6 ------ 2 files changed, 16 deletions(-) diff --git a/Documentation/yahns-rackup.pod b/Documentation/yahns-rackup.pod index 6172661..efdfb6d 100644 --- a/Documentation/yahns-rackup.pod +++ b/Documentation/yahns-rackup.pod @@ -159,16 +159,6 @@ The RACK_ENV variable is set by the aforementioned -E switch. If RACK_ENV is already set, it will be used unless -E is used. See rackup documentation for more details. -=head1 CAVEATS - -yahns is strict about buggy, non-compliant Rack applications. -Some existing servers work fine without "Content-Length" or -"Transfer-Encoding: chunked" response headers enforced by Rack::Lint. -Forgetting these headers with yahns causes clients to stall as they -assume more data is coming. Loading the Rack::ContentLength and/or -Rack::Chunked middlewares will set the necessary response headers -and fix your app. - =head1 CONTACT All feedback welcome via plain-text mail to L diff --git a/examples/yahns_rack_basic.conf.rb b/examples/yahns_rack_basic.conf.rb index 610a482..f3f8e6a 100644 --- a/examples/yahns_rack_basic.conf.rb +++ b/examples/yahns_rack_basic.conf.rb @@ -30,12 +30,6 @@ worker_threads 50 end -# note: Rack requires responses set "Content-Length" or use -# "Transfer-Encoding: chunked". Some Rack servers tolerate -# the lack of these, yahns does not. Thus you should load -# Rack::Chunked and/or Rack::ContentLength middleware in your -# config.ru to ensure clients know when your application -# responses terminate. app(:rack, "config.ru", preload: false) do listen 80 -- EW