yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] openssl_client: avoid undefined SSL_write behavior
@ 2016-08-06 10:45 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-08-06 10:45 UTC (permalink / raw)
  To: yahns-public

Sometimes apps may trigger zero-byte chunks in the response
body for whatever reason.  We should maintain consistent
behavior with the rest of kgio; and Ruby OpenSSL::SSL::SSLSocket
should maintain consistent behavior with the core IO class:

 *sigh*  The pain of being an early adopter; it feels like
 nobody deployed non-blocking servers using Ruby OpenSSL
 to production before me :x

 c.f. https://bugs.ruby-lang.org/issues/12126

 lib/yahns/openssl_client.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/yahns/openssl_client.rb b/lib/yahns/openssl_client.rb
index 439bc75..0d376bd 100644
--- a/lib/yahns/openssl_client.rb
+++ b/lib/yahns/openssl_client.rb
@@ -38,12 +38,14 @@ def yahns_init_ssl(ssl_ctx)
   def kgio_trywrite(buf)
+    len = buf.bytesize
+    return if len == 0
     buf = @ssl_blocked = buf.dup
     case rv = @ssl.write_nonblock(buf, exception: false)
     when :wait_readable, :wait_writable
       return rv # do not clear ssl_blocked
     when Integer
-      rv = buf.bytesize == rv ? nil : buf.byteslice(rv, buf.bytesize - rv)
+      rv = len == rv ? nil : buf.byteslice(rv, len - rv)
     @ssl_blocked = nil

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-06 10:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-06 10:45 [PATCH] openssl_client: avoid undefined SSL_write behavior Eric Wong

Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).