yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: Re: [PATCH] response: only stream "file" responses on known length
Date: Tue, 8 Nov 2016 23:28:56 +0000	[thread overview]
Message-ID: <20161108232856.GA29116@dcvr> (raw)
In-Reply-To: <20161108232140.21752-1-e@80x24.org>

Eric Wong <e@80x24.org> wrote:
> diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb

Oops, missed this :x

--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -125,7 +125,7 @@ def kv_str(buf, key, value)
   def http_response_write(res, opt)
     status, headers, body = res
     offset = 0
-    count = hijack = nil
+    count = hijack = clen = nil
     alive = @hs.next? && self.class.persistent_connections
     flags = MSG_DONTWAIT
     term = false

> @@ -152,7 +152,8 @@ def http_response_write(res, opt)
>            alive = false if value =~ /\bclose\b/i
>          when %r{\AContent-Length\z}i
>            term = true
> -          flags |= MSG_MORE if value.to_i > 0 && !hdr_only
> +          clen = value.to_i
> +          flags |= MSG_MORE if clen > 0 && !hdr_only
>            kv_str(buf, key, value)
>          when %r{\ATransfer-Encoding\z}i
>            term = true if value =~ /\bchunked\b/i

      reply	other threads:[~2016-11-08 23:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 23:21 [PATCH] response: only stream "file" responses on known length Eric Wong
2016-11-08 23:28 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161108232856.GA29116@dcvr \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).