yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] req_res: do not send 502 on catchall error if response buffered
@ 2016-11-12  1:37 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-11-12  1:37 UTC (permalink / raw)
  To: yahns-public

If we already started writing a response, we cannot be sending a
502 to inform a user a connection has failed.  This should
prevent errors from the OpenSSL layer about mismatched buffers
due to the combination of slow clients and upstreams prematurely
 lib/yahns/req_res.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/yahns/req_res.rb b/lib/yahns/req_res.rb
index 041b908..4ad8e5c 100644
--- a/lib/yahns/req_res.rb
+++ b/lib/yahns/req_res.rb
@@ -76,7 +76,7 @@ def yahns_step # yahns event loop entry point
     when Errno::ECONNREFUSED, Errno::ECONNRESET, Errno::EPIPE
-    c.proxy_err_response(502, self, e)
+    c.proxy_err_response(Yahns::WbufCommon === @resbuf ? nil : 502, self, e)
   def send_req_body_chunk(buf)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-12  1:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-12  1:37 [PATCH] req_res: do not send 502 on catchall error if response buffered Eric Wong

Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).