From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] stream_input: avoid allocation for common #read case
Date: Thu, 29 Dec 2016 07:08:18 +0000 [thread overview]
Message-ID: <20161229070818.GA2789@starla> (raw)
When entering StreamInput#read, it is common for @rbuf to
be drained and empty, meaning a simple String#clear can
be used in place of a more complex String#slice! String#replace
combo on an empty @rbuf.
While we're at it, we'll avoid an extra instructions for calling
`@rbuf.size` by storing the size in a local.
---
Of course, for TeeInput, there's bigger fish to fry with
IO#write: https://bugs.ruby-lang.org/issues/13085
Ugh, kicking myself so hard for not noticing that commit
3 years ago :<
lib/yahns/stream_input.rb | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/yahns/stream_input.rb b/lib/yahns/stream_input.rb
index 496faa2..a6190fc 100644
--- a/lib/yahns/stream_input.rb
+++ b/lib/yahns/stream_input.rb
@@ -43,8 +43,9 @@ def read(length = nil, rv = ''.dup)
length < 0 and raise ArgumentError, "negative length #{length} given"
rv.replace(@rbuf.slice!(0, length))
else
- to_read = length - @rbuf.size
- rv.replace(@rbuf.slice!(0, @rbuf.size))
+ cur = @rbuf.size
+ to_read = length - cur
+ cur == 0 ? rv.clear : rv.replace(@rbuf.slice!(0, cur))
until to_read == 0 || eof? || (rv.size > 0 && @chunked)
@client.yahns_read(to_read, @buf) or eof!
filter_body(@rbuf, @buf)
--
EW
reply other threads:[~2016-12-29 7:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229070818.GA2789@starla \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).