yahns Ruby server user/dev discussion
 help / color / Atom feed
* [PATCH] stream_input: avoid allocation for common #read case
@ 2016-12-29  7:08 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-12-29  7:08 UTC (permalink / raw)
  To: yahns-public

When entering StreamInput#read, it is common for @rbuf to
be drained and empty, meaning a simple String#clear can
be used in place of a more complex String#slice! String#replace
combo on an empty @rbuf.

While we're at it, we'll avoid an extra instructions for calling
`@rbuf.size` by storing the size in a local.
---
 Of course, for TeeInput, there's bigger fish to fry with
 IO#write: https://bugs.ruby-lang.org/issues/13085
 Ugh, kicking myself so hard for not noticing that commit
 3 years ago :<

 lib/yahns/stream_input.rb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/yahns/stream_input.rb b/lib/yahns/stream_input.rb
index 496faa2..a6190fc 100644
--- a/lib/yahns/stream_input.rb
+++ b/lib/yahns/stream_input.rb
@@ -43,8 +43,9 @@ def read(length = nil, rv = ''.dup)
         length < 0 and raise ArgumentError, "negative length #{length} given"
         rv.replace(@rbuf.slice!(0, length))
       else
-        to_read = length - @rbuf.size
-        rv.replace(@rbuf.slice!(0, @rbuf.size))
+        cur = @rbuf.size
+        to_read = length - cur
+        cur == 0 ? rv.clear : rv.replace(@rbuf.slice!(0, cur))
         until to_read == 0 || eof? || (rv.size > 0 && @chunked)
           @client.yahns_read(to_read, @buf) or eof!
           filter_body(@rbuf, @buf)
-- 
EW

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-29  7:08 [PATCH] stream_input: avoid allocation for common #read case Eric Wong

yahns Ruby server user/dev discussion

Archives are clonable:
	git clone --mirror https://yhbt.net/yahns-public
	git clone --mirror http://ou63pmih66umazou.onion/yahns-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.yahns

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox