From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 7AB16200E0; Thu, 29 Dec 2016 07:08:18 +0000 (UTC) Date: Thu, 29 Dec 2016 07:08:18 +0000 From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH] stream_input: avoid allocation for common #read case Message-ID: <20161229070818.GA2789@starla> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline List-Id: When entering StreamInput#read, it is common for @rbuf to be drained and empty, meaning a simple String#clear can be used in place of a more complex String#slice! String#replace combo on an empty @rbuf. While we're at it, we'll avoid an extra instructions for calling `@rbuf.size` by storing the size in a local. --- Of course, for TeeInput, there's bigger fish to fry with IO#write: https://bugs.ruby-lang.org/issues/13085 Ugh, kicking myself so hard for not noticing that commit 3 years ago :< lib/yahns/stream_input.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/yahns/stream_input.rb b/lib/yahns/stream_input.rb index 496faa2..a6190fc 100644 --- a/lib/yahns/stream_input.rb +++ b/lib/yahns/stream_input.rb @@ -43,8 +43,9 @@ def read(length = nil, rv = ''.dup) length < 0 and raise ArgumentError, "negative length #{length} given" rv.replace(@rbuf.slice!(0, length)) else - to_read = length - @rbuf.size - rv.replace(@rbuf.slice!(0, @rbuf.size)) + cur = @rbuf.size + to_read = length - cur + cur == 0 ? rv.clear : rv.replace(@rbuf.slice!(0, cur)) until to_read == 0 || eof? || (rv.size > 0 && @chunked) @client.yahns_read(to_read, @buf) or eof! filter_body(@rbuf, @buf) -- EW