yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] tee_input: simplify conditional for writing to temporary file
Date: Sat, 31 Dec 2016 04:39:49 +0000	[thread overview]
Message-ID: <20161231043949.7301-1-e@80x24.org> (raw)

It's rare to have an empty string returned by `read` since it
requires a length argument of zero (careless) or nil (danger!
OOM!).  Lets not try to optimize away a method dispatch in this
case by checking .size (optimized instruction in YARV).

Ruby IO#write already treats writing an empty string as a noop,
so no syscall is saved.

n.b.  `gets` can return an empty string, too, but that's also
dangerous w.r.t. memory usage on untrusted input.
---
 lib/yahns/tee_input.rb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/yahns/tee_input.rb b/lib/yahns/tee_input.rb
index 93ec148..90c8fd6 100644
--- a/lib/yahns/tee_input.rb
+++ b/lib/yahns/tee_input.rb
@@ -104,9 +104,7 @@ def consume!
   end
 
   def tee(buffer)
-    if buffer && buffer.size > 0
-      @tmp.write(buffer)
-    end
+    @tmp.write(buffer) if buffer
     buffer
   end
 
-- 
EW


                 reply	other threads:[~2016-12-31  4:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161231043949.7301-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).