yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] tee_input: simplify conditional for writing to temporary file
@ 2016-12-31  4:39 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-12-31  4:39 UTC (permalink / raw)
  To: yahns-public

It's rare to have an empty string returned by `read` since it
requires a length argument of zero (careless) or nil (danger!
OOM!).  Lets not try to optimize away a method dispatch in this
case by checking .size (optimized instruction in YARV).

Ruby IO#write already treats writing an empty string as a noop,
so no syscall is saved.

n.b.  `gets` can return an empty string, too, but that's also
dangerous w.r.t. memory usage on untrusted input.
 lib/yahns/tee_input.rb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/yahns/tee_input.rb b/lib/yahns/tee_input.rb
index 93ec148..90c8fd6 100644
--- a/lib/yahns/tee_input.rb
+++ b/lib/yahns/tee_input.rb
@@ -104,9 +104,7 @@ def consume!
   def tee(buffer)
-    if buffer && buffer.size > 0
-      @tmp.write(buffer)
-    end
+    @tmp.write(buffer) if buffer

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-12-31  4:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-31  4:39 [PATCH] tee_input: simplify conditional for writing to temporary file Eric Wong

Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).