yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] http_response: make response headers eligible for GC, sooner
@ 2017-02-17 20:11 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-02-17 20:11 UTC (permalink / raw)
  To: yahns-public

Iterating through the response body can be time consuming and
allocate memory, so nil out the headers object when we're done
with it to give Ruby a chance to recover the memory.
---
 lib/yahns/http_response.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb
index bde4b3f..865193d 100644
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -200,7 +200,7 @@ def http_response_write(res, opt)
       return step_write
     end
 
-    wbuf = rv = nil
+    headers = wbuf = rv = nil
     body.each do |x|
       if wbuf
         rv = wbuf.wbuf_write(self, x)
-- 
@@ -200,7 +200,7 @@ def http_response_write(res, opt)
       return step_write
     end
 
-    wbuf = rv = nil
+    headers = wbuf = rv = nil
     body.each do |x|
       if wbuf
         rv = wbuf.wbuf_write(self, x)
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-17 20:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-17 20:11 [PATCH] http_response: make response headers eligible for GC, sooner Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).