From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] http_client: clear backtrace on "wrong version number" in OpenSSL
Date: Sun, 8 Jul 2018 07:35:58 +0000 [thread overview]
Message-ID: <20180708073558.7319-1-e@80x24.org> (raw)
Errors which are the fault of the client should not generate
backtraces which can lead to dinky servers running out-of-space.
---
lib/yahns/http_client.rb | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/yahns/http_client.rb b/lib/yahns/http_client.rb
index d8154a4..fd97624 100644
--- a/lib/yahns/http_client.rb
+++ b/lib/yahns/http_client.rb
@@ -298,10 +298,18 @@ def handle_error(e)
when Unicorn::HttpParserError # try to tell the client they're bad
400
else
+ n = 500
+ case e.class.to_s
+ when 'OpenSSL::SSL::SSLError'
+ if e.message.include?('wrong version number')
+ n = nil
+ e.set_backtrace([])
+ end
+ end
Yahns::Log.exception(@hs.env["rack.logger"], "app error", e)
- 500
+ n
end
- kgio_trywrite(err_response(code))
+ kgio_trywrite(err_response(code)) if code
rescue
ensure
shutdown rescue nil
--
EW
reply other threads:[~2018-07-08 7:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180708073558.7319-1-e@80x24.org \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).