From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 514B41F62D for ; Sun, 8 Jul 2018 07:35:58 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH] http_client: clear backtrace on "wrong version number" in OpenSSL Date: Sun, 8 Jul 2018 07:35:58 +0000 Message-Id: <20180708073558.7319-1-e@80x24.org> List-Id: Errors which are the fault of the client should not generate backtraces which can lead to dinky servers running out-of-space. --- lib/yahns/http_client.rb | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/yahns/http_client.rb b/lib/yahns/http_client.rb index d8154a4..fd97624 100644 --- a/lib/yahns/http_client.rb +++ b/lib/yahns/http_client.rb @@ -298,10 +298,18 @@ def handle_error(e) when Unicorn::HttpParserError # try to tell the client they're bad 400 else + n = 500 + case e.class.to_s + when 'OpenSSL::SSL::SSLError' + if e.message.include?('wrong version number') + n = nil + e.set_backtrace([]) + end + end Yahns::Log.exception(@hs.env["rack.logger"], "app error", e) - 500 + n end - kgio_trywrite(err_response(code)) + kgio_trywrite(err_response(code)) if code rescue ensure shutdown rescue nil -- EW