yahns Ruby server user/dev discussion
 help / color / Atom feed
From: Eric Wong <e@80x24.org>
To: "Lin Jen-Shin (godfat)" <godfat@godfat.org>
Cc: yahns-public@yhbt.net
Subject: Re: [PATCH 1/2] Add QueueQuitter#closed? to queue_quitter_pipe.rb
Date: Sat, 8 Dec 2018 17:20:37 +0000
Message-ID: <20181208172037.6ccjk4jv3mb5x7il@dcvr> (raw)
In-Reply-To: <CAA2_N1vxBb42SP8yyHbb3-pTwEQ6YHRDFMk1kEdOMia6rJ3PUA@mail.gmail.com>

"Lin Jen-Shin (godfat)" <godfat@godfat.org> wrote:
> On Sat, Dec 8, 2018 at 7:36 PM Eric Wong <e@80x24.org> wrote:
> > Thanks for both patches, applied to https://yhbt.net/yahns.git
> >
> > Anything else?  Might tag a release, soon.
> 
> No, so far it's working great locally for me, thank you! I am very
> happy I can use yahns on Mac OSX now. So much easier to develop (and
> promote to the other developers)

Great, good to know.

> Previously I have no idea why but sleepy_penguin has some compile
> error which I can't figure out how to fix, and it really looks like
> it's Ruby's bug. They probably fixed it on one of the recent Ruby
> patch releases, and it works fine after the `closed?` patch.

Is it this?
https://bogomips.org/sleepy-penguin/20170415002501.19627-1-e@80x24.org/

Totally forgot about it, and I've even been using a FreeBSD a
bunch, just not with 3rd-party gems.

> It's unrelated but I am happy that yahns quits gracefully upon
> receiving SIGINT, while unicorn quits forcefully. I thought I might
> try to add something to the application to eliminate the difference,
> but since I could just run yahns everywhere I don't have to now.

Yes, I figured since the APIs are different (and I consider signal
handlers part of an API) it's safe to play around with the defaults
a little as long as it's non-destructive on errors.

One downside with graceful-shutdown-by-default and the generous
timeouts is I've had it cause rebooting a machine to take way
longer than expected, which increased downtime :x

> > Getting rid of kgio is going to be a bit of work...
> 
> This really comes with a long way, and on the bright side, we're
> moving forward :) Thank you for all the works!

You're welcome.

Btw, which versions of Ruby are you using?  I'm pretty sure
Ruby 2.0 support compatibility is no longer necessary, these
days; so we can rely on "exception: false" in more places
and slowly remove kgio dependencies.

Fwiw, I'm prepping a fork of yahns to demo Thread::Light
<https://bugs.ruby-lang.org/issues/13618>, too
working on lib/yahns/proxy_pass.rb was too much of a nightmare;
so I wanted to keep all the Ruby parts synchronous.

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-08  8:30 Lin Jen-Shin
2018-12-08  8:30 ` [PATCH 2/2] @srv.shutdown could raise Errno::ENOTCONN Lin Jen-Shin
2018-12-08 11:36 ` [PATCH 1/2] Add QueueQuitter#closed? to queue_quitter_pipe.rb Eric Wong
2018-12-08 11:52   ` Lin Jen-Shin (godfat)
2018-12-08 17:20     ` Eric Wong [this message]
2018-12-09  8:49       ` Lin Jen-Shin (godfat)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181208172037.6ccjk4jv3mb5x7il@dcvr \
    --to=e@80x24.org \
    --cc=godfat@godfat.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

yahns Ruby server user/dev discussion

Archives are clonable:
	git clone --mirror https://yhbt.net/yahns-public
	git clone --mirror http://ou63pmih66umazou.onion/yahns-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.yahns

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git