From: Eric Wong <firstname.lastname@example.org>
To: "Lin Jen-Shin (godfat)" <email@example.com>
Subject: Re: [PATCH 1/2] Add QueueQuitter#closed? to queue_quitter_pipe.rb
Date: Sat, 8 Dec 2018 17:20:37 +0000 [thread overview]
Message-ID: <20181208172037.6ccjk4jv3mb5x7il@dcvr> (raw)
"Lin Jen-Shin (godfat)" <firstname.lastname@example.org> wrote:
> On Sat, Dec 8, 2018 at 7:36 PM Eric Wong <email@example.com> wrote:
> > Thanks for both patches, applied to https://yhbt.net/yahns.git
> > Anything else? Might tag a release, soon.
> No, so far it's working great locally for me, thank you! I am very
> happy I can use yahns on Mac OSX now. So much easier to develop (and
> promote to the other developers)
Great, good to know.
> Previously I have no idea why but sleepy_penguin has some compile
> error which I can't figure out how to fix, and it really looks like
> it's Ruby's bug. They probably fixed it on one of the recent Ruby
> patch releases, and it works fine after the `closed?` patch.
Is it this?
Totally forgot about it, and I've even been using a FreeBSD a
bunch, just not with 3rd-party gems.
> It's unrelated but I am happy that yahns quits gracefully upon
> receiving SIGINT, while unicorn quits forcefully. I thought I might
> try to add something to the application to eliminate the difference,
> but since I could just run yahns everywhere I don't have to now.
Yes, I figured since the APIs are different (and I consider signal
handlers part of an API) it's safe to play around with the defaults
a little as long as it's non-destructive on errors.
One downside with graceful-shutdown-by-default and the generous
timeouts is I've had it cause rebooting a machine to take way
longer than expected, which increased downtime :x
> > Getting rid of kgio is going to be a bit of work...
> This really comes with a long way, and on the bright side, we're
> moving forward :) Thank you for all the works!
Btw, which versions of Ruby are you using? I'm pretty sure
Ruby 2.0 support compatibility is no longer necessary, these
days; so we can rely on "exception: false" in more places
and slowly remove kgio dependencies.
Fwiw, I'm prepping a fork of yahns to demo Thread::Light
working on lib/yahns/proxy_pass.rb was too much of a nightmare;
so I wanted to keep all the Ruby parts synchronous.
next prev parent reply other threads:[~2018-12-08 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 8:30 [PATCH 1/2] Add QueueQuitter#closed? to queue_quitter_pipe.rb Lin Jen-Shin
2018-12-08 8:30 ` [PATCH 2/2] @srv.shutdown could raise Errno::ENOTCONN Lin Jen-Shin
2018-12-08 11:36 ` [PATCH 1/2] Add QueueQuitter#closed? to queue_quitter_pipe.rb Eric Wong
2018-12-08 11:52 ` Lin Jen-Shin (godfat)
2018-12-08 17:20 ` Eric Wong [this message]
2018-12-09 8:49 ` Lin Jen-Shin (godfat)
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).