From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] server_mp: remove redundant srand call
Date: Fri, 28 Dec 2018 07:40:42 +0000 [thread overview]
Message-ID: <20181228074042.21121-1-e@80x24.org> (raw)
Ruby itself has tests for RNG reseeding at fork, so no need for
belt-and-suspenders code on our end.
---
lib/yahns/server_mp.rb | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/yahns/server_mp.rb b/lib/yahns/server_mp.rb
index 7b2f9b7..8752a08 100644
--- a/lib/yahns/server_mp.rb
+++ b/lib/yahns/server_mp.rb
@@ -31,8 +31,6 @@ def worker_atfork_internal(worker)
# daemon_pipe may be true for non-initial workers
@daemon_pipe = @daemon_pipe.close if @daemon_pipe.respond_to?(:close)
- srand # in case this pops up again: https://bugs.ruby-lang.org/issues/4338
-
# The OpenSSL PRNG is seeded with only the pid, and apps with frequently
# dying workers can recycle pids
OpenSSL::Random.seed(rand.to_s) if defined?(OpenSSL::Random)
--
EW
reply other threads:[~2018-12-28 7:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181228074042.21121-1-e@80x24.org \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).