yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] extras/exec_cgi: remove unecessary .freeze calls
@ 2018-12-28 19:43 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2018-12-28 19:43 UTC (permalink / raw)
  To: yahns-public

Operations via Array#map are NOT optimized away by opt_str_lit
in the VM, and they're unnecessary anyways with the
"frozen_string_literal: true" comment in Ruby 2.3+.
---
 extras/exec_cgi.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extras/exec_cgi.rb b/extras/exec_cgi.rb
index 2746c09..8a1939d 100644
--- a/extras/exec_cgi.rb
+++ b/extras/exec_cgi.rb
@@ -82,7 +82,7 @@ def close
     SERVER_PROTOCOL
     SERVER_SOFTWARE
     SCRIPT_NAME
-  ).map(&:freeze)  # frozen strings are faster for Hash assignments
+  )
 
   def initialize(*args)
     @env = Hash === args[0] ? args.shift : {}
-- 
@@ -82,7 +82,7 @@ def close
     SERVER_PROTOCOL
     SERVER_SOFTWARE
     SCRIPT_NAME
-  ).map(&:freeze)  # frozen strings are faster for Hash assignments
+  )
 
   def initialize(*args)
     @env = Hash === args[0] ? args.shift : {}
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-12-28 19:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-28 19:43 [PATCH] extras/exec_cgi: remove unecessary .freeze calls Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).