yahns Ruby server user/dev discussion
 help / color / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH 1/2] server: respect shutdown_timeout
Date: Sun, 30 Dec 2018 02:33:17 +0000
Message-ID: <20181230023318.27753-2-e@80x24.org> (raw)
In-Reply-To: <20181230023318.27753-1-e@80x24.org>

It seems there is still a bug in the proxy code which causes
this timeout expiries to be missed.
---
 lib/yahns/server.rb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/yahns/server.rb b/lib/yahns/server.rb
index 583fd38..128b894 100644
--- a/lib/yahns/server.rb
+++ b/lib/yahns/server.rb
@@ -500,6 +500,8 @@ def dropping(fdmap)
     if drop_acceptors[0] || fdmap.size > 0
       timeout = @shutdown_expire < Yahns.now ? -1 : @shutdown_timeout
       n = fdmap.desperate_expire(timeout)
+      return false if timeout == -1
+
       $0 = "yahns quitting, #{n} FD(s) remain"
       true
     else
-- 
EW


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-30  2:33 [PATCH 0/2] shutdown stuff Eric Wong
2018-12-30  2:33 ` Eric Wong [this message]
2018-12-30  2:33 ` [PATCH 2/2] server: extra shutdown timeout debugging Eric Wong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181230023318.27753-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

yahns Ruby server user/dev discussion

Archives are clonable:
	git clone --mirror https://yhbt.net/yahns-public
	git clone --mirror http://ou63pmih66umazou.onion/yahns-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.yahns

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git