From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH 2/2] server: extra shutdown timeout debugging
Date: Sun, 30 Dec 2018 02:33:18 +0000 [thread overview]
Message-ID: <20181230023318.27753-3-e@80x24.org> (raw)
In-Reply-To: <20181230023318.27753-1-e@80x24.org>
Still not sure what's going on with the proxy_pass code,
but something in the Fdmap code is causing shutdowns to
take way longer than expected...
---
lib/yahns/server.rb | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/lib/yahns/server.rb b/lib/yahns/server.rb
index 128b894..2ad65a9 100644
--- a/lib/yahns/server.rb
+++ b/lib/yahns/server.rb
@@ -500,7 +500,18 @@ def dropping(fdmap)
if drop_acceptors[0] || fdmap.size > 0
timeout = @shutdown_expire < Yahns.now ? -1 : @shutdown_timeout
n = fdmap.desperate_expire(timeout)
- return false if timeout == -1
+ return false if n == 0 # all done!
+
+ # FIXME: sometimes shutdowns take a long time when using proxy_pass
+ # Still not sure what's going on and it takes a while to reproduce..
+ if timeout == -1
+ @logger.error(
+"exiting on shutdown_timeout=#@shutdown_timeout #{fdmap.size} FD(s) remain"
+ )
+
+ system('lsof', '-n', '-p', "#$$") if RUBY_PLATFORM =~ /linux/
+ return false
+ end
$0 = "yahns quitting, #{n} FD(s) remain"
true
--
EW
prev parent reply other threads:[~2018-12-30 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 2:33 [PATCH 0/2] shutdown stuff Eric Wong
2018-12-30 2:33 ` [PATCH 1/2] server: respect shutdown_timeout Eric Wong
2018-12-30 2:33 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181230023318.27753-3-e@80x24.org \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).