From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id EE8701F7E9 for ; Sun, 30 Dec 2018 02:33:23 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH 2/2] server: extra shutdown timeout debugging Date: Sun, 30 Dec 2018 02:33:18 +0000 Message-Id: <20181230023318.27753-3-e@80x24.org> In-Reply-To: <20181230023318.27753-1-e@80x24.org> References: <20181230023318.27753-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Still not sure what's going on with the proxy_pass code, but something in the Fdmap code is causing shutdowns to take way longer than expected... --- lib/yahns/server.rb | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/yahns/server.rb b/lib/yahns/server.rb index 128b894..2ad65a9 100644 --- a/lib/yahns/server.rb +++ b/lib/yahns/server.rb @@ -500,7 +500,18 @@ def dropping(fdmap) if drop_acceptors[0] || fdmap.size > 0 timeout = @shutdown_expire < Yahns.now ? -1 : @shutdown_timeout n = fdmap.desperate_expire(timeout) - return false if timeout == -1 + return false if n == 0 # all done! + + # FIXME: sometimes shutdowns take a long time when using proxy_pass + # Still not sure what's going on and it takes a while to reproduce.. + if timeout == -1 + @logger.error( +"exiting on shutdown_timeout=#@shutdown_timeout #{fdmap.size} FD(s) remain" + ) + + system('lsof', '-n', '-p', "#$$") if RUBY_PLATFORM =~ /linux/ + return false + end $0 = "yahns quitting, #{n} FD(s) remain" true -- EW