From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] wbuf: use IO#write directly in Ruby 2.5+ for writev
Date: Sat, 5 Jan 2019 21:04:31 +0000 [thread overview]
Message-ID: <20190105210431.26013-1-e@80x24.org> (raw)
Slowly removing kgio dependencies...
---
lib/yahns/wbuf.rb | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/yahns/wbuf.rb b/lib/yahns/wbuf.rb
index 3abc5f9..d3552b3 100644
--- a/lib/yahns/wbuf.rb
+++ b/lib/yahns/wbuf.rb
@@ -31,6 +31,7 @@
class Yahns::Wbuf # :nodoc:
include Yahns::WbufCommon
attr_reader :busy
+ IO_WRITEV = RUBY_VERSION.to_r >= 2.5 # IO#write uses writev
def initialize(body, persist)
@tmpio = nil
@@ -40,9 +41,15 @@ def initialize(body, persist)
@busy = false
end
- def wbuf_writev(buf)
- @tmpio.kgio_writev(buf)
- buf.inject(0) { |n, s| n += s.size }
+ if IO_WRITEV
+ def wbuf_writev(buf)
+ @tmpio.write(*buf)
+ end
+ else
+ def wbuf_writev(buf)
+ @tmpio.kgio_writev(buf)
+ buf.inject(0) { |n, s| n += s.size }
+ end
end
def wbuf_write(c, buf)
--
EW
reply other threads:[~2019-01-05 21:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190105210431.26013-1-e@80x24.org \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).