yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] worker: workaround old F_SETPIPE_SZ bug
@ 2019-05-04 16:34 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-05-04 16:34 UTC (permalink / raw)
  To: yahns-public

Linux before 4.9 (and before 3.16.57) failed to account
for the existing size of a pipe before checking system
resource limits and would return EPERM in that case.

https://80x24.org/mirrors/linux.git/commit?id=b0b91d18e2e97b741b294af9333824ecc3fadfd8
https://lore.kernel.org/lkml/?q=s%3A%22fix+limit+checking+in+pipe_set_size%22

Based on a patch by Stephen Demjanenko for unicorn:
https://bogomips.org/unicorn-public/1556922018-24096-1-git-send-email-sdemjanenko@gmail.com/
---
 lib/yahns/worker.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/yahns/worker.rb b/lib/yahns/worker.rb
index 0355629..ec5be23 100644
--- a/lib/yahns/worker.rb
+++ b/lib/yahns/worker.rb
@@ -14,8 +14,8 @@ def initialize(nr)
       # F_SETPIPE_SZ = 1031, PAGE_SIZE = 4096
       # (fcntl will handle minimum size on platforms where PAGE_SIZE > 4096)
       @to_io.fcntl(1031, 4096)
-    rescue Errno::EINVAL
-      # old kernel
+    rescue SystemCallError
+      # old kernel (EINVAL, EPERM)
     end if RUBY_PLATFORM =~ /\blinux\b/
   end
 
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-05-04 16:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-04 16:34 [PATCH] worker: workaround old F_SETPIPE_SZ bug Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).