From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 1E8511F45F for ; Sat, 4 May 2019 16:34:23 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH] worker: workaround old F_SETPIPE_SZ bug Date: Sat, 4 May 2019 16:34:22 +0000 Message-Id: <20190504163422.19834-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Linux before 4.9 (and before 3.16.57) failed to account for the existing size of a pipe before checking system resource limits and would return EPERM in that case. https://80x24.org/mirrors/linux.git/commit?id=b0b91d18e2e97b741b294af9333824ecc3fadfd8 https://lore.kernel.org/lkml/?q=s%3A%22fix+limit+checking+in+pipe_set_size%22 Based on a patch by Stephen Demjanenko for unicorn: https://bogomips.org/unicorn-public/1556922018-24096-1-git-send-email-sdemjanenko@gmail.com/ --- lib/yahns/worker.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/yahns/worker.rb b/lib/yahns/worker.rb index 0355629..ec5be23 100644 --- a/lib/yahns/worker.rb +++ b/lib/yahns/worker.rb @@ -14,8 +14,8 @@ def initialize(nr) # F_SETPIPE_SZ = 1031, PAGE_SIZE = 4096 # (fcntl will handle minimum size on platforms where PAGE_SIZE > 4096) @to_io.fcntl(1031, 4096) - rescue Errno::EINVAL - # old kernel + rescue SystemCallError + # old kernel (EINVAL, EPERM) end if RUBY_PLATFORM =~ /\blinux\b/ end -- EW