yahns Ruby server user/dev discussion
 help / color / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] doc: favor File.read over IO.read to ease review
Date: Fri, 10 May 2019 02:44:40 +0000
Message-ID: <20190510024440.13178-1-e@80x24.org> (raw)

IO.read may invoke subprocesses, which can set off
security warnings.
---
 Documentation/yahns_config.pod | 6 +++---
 test/helper.rb                 | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/yahns_config.pod b/Documentation/yahns_config.pod
index 01b1bf9..737e085 100644
--- a/Documentation/yahns_config.pod
+++ b/Documentation/yahns_config.pod
@@ -436,15 +436,15 @@ An example which seems to work is:
   require 'openssl'
   ssl_ctx = OpenSSL::SSL::SSLContext.new
   ssl_ctx.cert = OpenSSL::X509::Certificate.new(
-    IO.read('/etc/ssl/certs/example.crt')
+    File.read('/etc/ssl/certs/example.crt')
   )
   ssl_ctx.extra_chain_cert = [
     OpenSSL::X509::Certificate.new(
-      IO.read('/etc/ssl/certs/chain.crt')
+      File.read('/etc/ssl/certs/chain.crt')
     )
   ]
   ssl_ctx.key = OpenSSL::PKey::RSA.new(
-    IO.read('/etc/ssl/private/example.key')
+    File.read('/etc/ssl/private/example.key')
   )
 
   # use defaults provided by Ruby on top of OpenSSL,
diff --git a/test/helper.rb b/test/helper.rb
index 550a0f1..f9370a4 100644
--- a/test/helper.rb
+++ b/test/helper.rb
@@ -158,7 +158,7 @@ def skip_skb_mem
   [ [ '/proc/sys/net/ipv4/tcp_rmem', "4096	87380	6291456\n" ],
     [ '/proc/sys/net/ipv4/tcp_wmem', "4096	16384	4194304\n" ]
   ].each do |file, expect|
-    val = IO.read(file)
+    val = File.read(file)
     val == expect or skip "#{file} had: #{val}expected: #{expect}"
   end
 end
-- 
EW


                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190510024440.13178-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

yahns Ruby server user/dev discussion

Archives are clonable:
	git clone --mirror https://yhbt.net/yahns-public
	git clone --mirror http://ou63pmih66umazou.onion/yahns-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.yahns

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox