yahns Ruby server user/dev discussion
 help / color / Atom feed
* [PATCH] doc: favor File.read over IO.read to ease review
@ 2019-05-10  2:44 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-05-10  2:44 UTC (permalink / raw)
  To: yahns-public

IO.read may invoke subprocesses, which can set off
security warnings.
---
 Documentation/yahns_config.pod | 6 +++---
 test/helper.rb                 | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/yahns_config.pod b/Documentation/yahns_config.pod
index 01b1bf9..737e085 100644
--- a/Documentation/yahns_config.pod
+++ b/Documentation/yahns_config.pod
@@ -436,15 +436,15 @@ An example which seems to work is:
   require 'openssl'
   ssl_ctx = OpenSSL::SSL::SSLContext.new
   ssl_ctx.cert = OpenSSL::X509::Certificate.new(
-    IO.read('/etc/ssl/certs/example.crt')
+    File.read('/etc/ssl/certs/example.crt')
   )
   ssl_ctx.extra_chain_cert = [
     OpenSSL::X509::Certificate.new(
-      IO.read('/etc/ssl/certs/chain.crt')
+      File.read('/etc/ssl/certs/chain.crt')
     )
   ]
   ssl_ctx.key = OpenSSL::PKey::RSA.new(
-    IO.read('/etc/ssl/private/example.key')
+    File.read('/etc/ssl/private/example.key')
   )
 
   # use defaults provided by Ruby on top of OpenSSL,
diff --git a/test/helper.rb b/test/helper.rb
index 550a0f1..f9370a4 100644
--- a/test/helper.rb
+++ b/test/helper.rb
@@ -158,7 +158,7 @@ def skip_skb_mem
   [ [ '/proc/sys/net/ipv4/tcp_rmem', "4096	87380	6291456\n" ],
     [ '/proc/sys/net/ipv4/tcp_wmem', "4096	16384	4194304\n" ]
   ].each do |file, expect|
-    val = IO.read(file)
+    val = File.read(file)
     val == expect or skip "#{file} had: #{val}expected: #{expect}"
   end
 end
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-10  2:44 [PATCH] doc: favor File.read over IO.read to ease review Eric Wong

yahns Ruby server user/dev discussion

Archives are clonable:
	git clone --mirror https://yhbt.net/yahns-public
	git clone --mirror http://ou63pmih66umazou.onion/yahns-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.yahns

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox