From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id CF5B31F45F for ; Fri, 10 May 2019 02:44:40 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH] doc: favor File.read over IO.read to ease review Date: Fri, 10 May 2019 02:44:40 +0000 Message-Id: <20190510024440.13178-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: IO.read may invoke subprocesses, which can set off security warnings. --- Documentation/yahns_config.pod | 6 +++--- test/helper.rb | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/yahns_config.pod b/Documentation/yahns_config.pod index 01b1bf9..737e085 100644 --- a/Documentation/yahns_config.pod +++ b/Documentation/yahns_config.pod @@ -436,15 +436,15 @@ An example which seems to work is: require 'openssl' ssl_ctx = OpenSSL::SSL::SSLContext.new ssl_ctx.cert = OpenSSL::X509::Certificate.new( - IO.read('/etc/ssl/certs/example.crt') + File.read('/etc/ssl/certs/example.crt') ) ssl_ctx.extra_chain_cert = [ OpenSSL::X509::Certificate.new( - IO.read('/etc/ssl/certs/chain.crt') + File.read('/etc/ssl/certs/chain.crt') ) ] ssl_ctx.key = OpenSSL::PKey::RSA.new( - IO.read('/etc/ssl/private/example.key') + File.read('/etc/ssl/private/example.key') ) # use defaults provided by Ruby on top of OpenSSL, diff --git a/test/helper.rb b/test/helper.rb index 550a0f1..f9370a4 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -158,7 +158,7 @@ def skip_skb_mem [ [ '/proc/sys/net/ipv4/tcp_rmem', "4096 87380 6291456\n" ], [ '/proc/sys/net/ipv4/tcp_wmem', "4096 16384 4194304\n" ] ].each do |file, expect| - val = IO.read(file) + val = File.read(file) val == expect or skip "#{file} had: #{val}expected: #{expect}" end end -- EW