yahns Ruby server user/dev discussion
 help / color / Atom feed
From: Eric Wong <bofh@yhbt.net>
To: yahns-public@yhbt.net
Subject: [PATCH] extras/try_gzip_static: set "Vary: Accept-Encoding" on gzip
Date: Sat,  4 Apr 2020 23:50:47 +0000
Message-ID: <20200404235047.16621-1-bofh@yhbt.net> (raw)

Some rare clients may not support gzip.  So ensure cache layers
don't inadvertantly serve cached content to them.
---
 extras/try_gzip_static.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/extras/try_gzip_static.rb b/extras/try_gzip_static.rb
index 4dd435a..a2dd155 100644
--- a/extras/try_gzip_static.rb
+++ b/extras/try_gzip_static.rb
@@ -79,7 +79,10 @@ def fheader(env, path, st, gz_st = nil, len = nil)
       "Accept-Ranges" => "bytes",
     }
     h["Cache-Control"] = "no-transform" unless mime =~ %r{\Atext\/}
-    h["Content-Encoding"] = "gzip" if gz_st
+    if gz_st
+      h["Content-Encoding"] = "gzip"
+      h["Vary"] = "Accept-Encoding"
+    end
     h
   end
 

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200404235047.16621-1-bofh@yhbt.net \
    --to=bofh@yhbt.net \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

yahns Ruby server user/dev discussion

Archives are clonable:
	git clone --mirror https://yhbt.net/yahns-public
	git clone --mirror http://ou63pmih66umazou.onion/yahns-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.yahns

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git