yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] extras/try_gzip_static: set "Vary: Accept-Encoding" on gzip
@ 2020-04-04 23:50 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-04-04 23:50 UTC (permalink / raw)
  To: yahns-public

Some rare clients may not support gzip.  So ensure cache layers
don't inadvertantly serve cached content to them.
---
 extras/try_gzip_static.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/extras/try_gzip_static.rb b/extras/try_gzip_static.rb
index 4dd435a..a2dd155 100644
--- a/extras/try_gzip_static.rb
+++ b/extras/try_gzip_static.rb
@@ -79,7 +79,10 @@ def fheader(env, path, st, gz_st = nil, len = nil)
       "Accept-Ranges" => "bytes",
     }
     h["Cache-Control"] = "no-transform" unless mime =~ %r{\Atext\/}
-    h["Content-Encoding"] = "gzip" if gz_st
+    if gz_st
+      h["Content-Encoding"] = "gzip"
+      h["Vary"] = "Accept-Encoding"
+    end
     h
   end
 

^ permalink raw reply related	[flat|nested] only message in thread
only message in thread, other threads:[~2020-04-04 23:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-04 23:50 [PATCH] extras/try_gzip_static: set "Vary: Accept-Encoding" on gzip Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).